Add reshardSplitShardCountSummary field to ShardSearchRequest and friends #135804
+535
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
commented
Oct 1, 2025
| searchShardsGroup.preFiltered(), | ||
| searchShardsGroup.skipped() | ||
| searchShardsGroup.skipped(), | ||
| 0 // TODO |
There was a problem hiding this comment.
This is CCS code path, will remain stubbed with a better comment.
lkts
commented
Oct 1, 2025
| false, | ||
| false | ||
| false, | ||
| 0 // TODO |
There was a problem hiding this comment.
This is CCS code path, will remain stubbed with a better comment.
lkts
commented
Oct 1, 2025
| false, | ||
| false | ||
| false, | ||
| 0 // TODO |
There was a problem hiding this comment.
This is for PIT, we need a custom calculation here but it's doable.
lkts
force-pushed
the
resharding_checksum_search
branch
from
73d23a4 to
2016bfd
Compare
|
Test failure is a problem fixed by #135873. |
lkts
added
>non-issue
:Distributed Indexing/Distributed
elasticsearchmachine
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
lkts
force-pushed
the
resharding_checksum_search
branch
from
29e8862 to
20a7df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
reshardSplitShardCountSummaryis a field special to resharding functionality. The final goal is forreshardSplitShardCountSummaryto be used insideEngine#wrapDirectoryReaderviaIndexShard#acquireSearcher(Supplier)since it is needed for resharding reader wrapper to work. This PR makes so this value is available to the immediate callers ofacquireSearcher(Supplier)like f.e.SearchService#createOrGetReaderContext().Note that this PR does not change all constructors of
ShardSearchRequestin order to keep the size down. Some usages (like ESQL) also need special logic to calculate the value before passing it toShardSearchRequest. This will be done in the follow up. Currently a default value of 0 is used.